See my reply.
Otavio,
Please see the reply too.
> -----Original Message-----
> From: [email protected]
> [mailto:[email protected]] On
> Behalf Of Matthew Garrett
> Sent: 2010?10?11? 20:51
> To: Huang, FrankR
> Cc: Otavio Salvador; Adam Jackson; [email protected]; Geode Mailing
> List; Julien Cristau
> Subject: Re: [Xorg-driver-geode] xf86-video-geode: Changes to 'master'
>
> Your change means that the function will always return MODE_OK. If
> that's what you want to happen, just remove the entirity of the
> function other than the return statement. There's no point in performing
> various checks that result in the same outcome. You'll probably be able
> to delete some other code as a consequence.
Actually, what I want to happen is for "always return MODE_OK". Just as
you(Julien, Ajax) have said, this driver's mode_valid() function should filter
out the modes that can not be supported by hardware. I totally agree with this
point.
But unfortunately, the structure of this function has changed with the patch
5/29/2010.
http://cgit.freedesktop.org/xorg/driver/xf86-video-geode/commit/?id=e9447f5335681a78cf87ebf8c9659a6fecfc9746
It is as follow:
1)... return MODE_OK
2)... return MODE_OK
3)... return MODE_OK
4)... return MODE_BAD
>From my point, This is not reasonable. ATI&&INTEL mode_valid function is as
>follow:
1)... return MODE_XXX
2)... return MODE_XXX
3)... return MODE_XXX
4)... return MODE_OK
That is what we also want in geode driver.
WHAT I SUGGEST IS THAT WE JUST RETURN "MODE_OK" FOR THIS FUNCTION NOW.
>
> But the *correct* fix is to figure out why valid modes are being
> rejected. The patch you've posted is just a workaround for some other
> bug, and introduces more bugs in the process. That's why people are
> calling it wrong.
The reason why valid modes are being pruned is due to the MODE_BAD return in
this function. In the following function xf86PruneInvalidModes, the modes that
is not MODE_OK will be deleted. It is very clear. Just look at the code and you
can get the answer. So I don't know "introduces more bugs" means what? What bug
exactly will be introduced? If you take the example Ajax gave(1920x1440 160),
we can add code to filter out that mode in the mode_valid function.
>
> --
> Matthew Garrett | [email protected]
> _______________________________________________
> Xorg-driver-geode mailing list
> [email protected]
> http://lists.x.org/mailman/listinfo/xorg-driver-geode
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
