Dear Immi, I seem to remember back when you first proposed the patch I had a suggestion for a way to make the file format change essentially backwards compatible. (It wasn't 100% perfect but might be simplest). I forget what it was exactly and since I'm in the middle of moving from San Francisco to New York with kids, I don't want to dig too hard. In general though, my suggestion is not to worry too much, unless Daniel's branch becomes in widespread use -- this is the kind of thing I obsess about when I incorporate patches into the main codebranch, i.e. you should imagine that if/when I ever find the time to get to it, what will make it into the main codebase is not quite your patch but rather something conceptually similar but addressing issues such as backwards compatibility of file format. You guys should feel free to innovate, and I'll feel free to hold you back by not incorporating the changes.
Best, Denis On 09/01/2016 07:00 AM, Immi Halupczok wrote: > Hi, > > My modifications are on > https://github.com/immi-h/xournal.git > in the branch line-widths. > > I've been thinking a bit more about it: As I had written before, it > somewhat changes the file format (to be able to store the line width at > the very beginning). However, I think that after all, it's quite bad if > old versions of xournal are not able to read new files. (I don't know > whether that's also your opinion.) I thought about changing the new file > format in such a way that old xournal versions would simply ignore the > additional information (by simply putting the additional information > into another attribute), but the latest version of xournal doesn't > accept files with additional attributes anymore, so that doesn't work. > > For this reason, I'm now thinking about splitting my modifications in > two parts: > - everything that doesn't need a changed file format (in particular the > optimizations) > - change the file format only when the file format is changed anyway > also for other reasons (maybe when there's a major new version of > xournal or something like that) > > Suggestions? Comments? > > Best, > Immi > > > > > > > Am 31.08.2016 um 19:24 schrieb dmg: >> hi Immi, >> >> Sorry about it. >> >> My personal preference is to use github. I think what we need to do is >> to set a mirror of xournal in github, >> and use this as the "central" collaboration point. From there Denis can >> decide what he wants to bring >> into it, but at least we can each try the development of the other. >> >> what do you think? I have created it just now: >> >> github.com/xournal/xournal <http://github.com/xournal/xournal> >> >> i will make sure it is updated to Denis repo. Immi, you can create your >> fork, add your feature and we can all test it. >> I can also integrate it to my "next" version of the repo. >> >> --dmg >> >> On Wed, Aug 31, 2016 at 9:50 AM, Immi Halupczok <xour...@karimmi.de >> <mailto:xour...@karimmi.de>> wrote: >> >> Hi, >> >> some time ago, I wrote to this mailing list about a patch improving (a) >> performance and (b) how line endings look. I didn't get any reply. Is >> there no interest in this (or did just nobody feel responsible to answer >> or so)? >> >> (What's the right way in which to contribute to xournal?) >> >> There are also various other little improvements I might want to >> contribute, but this of course only makes sense if there's interest >> in it. >> >> Best, >> Immi >> >> >> ------------------------------------------------------------------------------ >> _______________________________________________ >> Xournal-devel mailing list >> Xournal-devel@lists.sourceforge.net >> <mailto:Xournal-devel@lists.sourceforge.net> >> https://lists.sourceforge.net/lists/listinfo/xournal-devel >> <https://lists.sourceforge.net/lists/listinfo/xournal-devel> >> >> >> >> >> -- >> --dmg >> >> --- >> Daniel M. German >> http://turingmachine.org > > ------------------------------------------------------------------------------ > _______________________________________________ > Xournal-devel mailing list > Xournal-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/xournal-devel > -- Denis Auroux UC Berkeley, Department of Mathematics 817 Evans Hall, Berkeley CA 94720-3840, USA aur...@math.berkeley.edu ------------------------------------------------------------------------------ _______________________________________________ Xournal-devel mailing list Xournal-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xournal-devel
