>> I've been thinking a bit more about it: As I had written before, it
>> somewhat changes the file format (to be able to store the line width at
>> the very beginning). However, I think that after all, it's quite bad if
>> old versions of xournal are not able to read new files. (I don't know
>> whether that's also your opinion.) I thought about changing the new file
>> format in such a way that old xournal versions would simply ignore the
>> additional information (by simply putting the additional information
>> into another attribute), but the latest version of xournal doesn't
>> accept files with additional attributes anymore, so that doesn't work.
I was looking at your code. I think it would be very useful to separate
conceptually the two changes, as you said before. It will also be very
useful to us that you describe (ideally in the log of the commit) a bit
in detail the changes. E.g. Motivation, how you did it, impact on
xournal (changes in file format, for example).
So let us split the changes into conceptual changes: one for the line
widths, and the other for the optimization.
Also, regarding backwards compatibility. Older versions of xournal can
parse new files, as long as the features are new elements in the XML,
but not if there are new attributes.
In second thoughts, I think it would be good to use the pull requests,
even if we don't actually merge them directly using github, but it will
let us do code review of the changes, and ask for specific
clarifications. For example, in the case of your code, I am curious to
know what the purpose of the functions are:
void make_canvas_stroke_disc(struct Item *item, double * pt, double * w)
void make_canvas_stroke_trapeze(struct Item *item, double * pt, double * w)
Regarding Denis suggestion, let us keep compatibility with every Xournal
version to the max, while we try to innovate. And let us keep every few
feature in its own branch, while we still try to have keep the "next"
version with these features.
thanks Immi, Denis,
--daniel
--
Daniel M. German "One reason that life
is complex is that
it has a real part and
Andrew Koenig -> an imaginary part."
http://turingmachine.org/
http://silvernegative.com/
dmg (at) uvic (dot) ca
replace (at) with @ and (dot) with .
------------------------------------------------------------------------------
_______________________________________________
Xournal-devel mailing list
Xournal-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xournal-devel
