Immi Halupczok twisted the bytes to say:
>> I was looking at your code. I think it would be very useful to separate
>> conceptually the two changes, as you said before. It will also be very
>> useful to us that you describe (ideally in the log of the commit) a bit
>> in detail the changes. E.g. Motivation, how you did it, impact on
>> xournal (changes in file format, for example).
>>
>> So let us split the changes into conceptual changes: one for the line
>> widths, and the other for the optimization.
Immi> It turns out that splitting things would be some work, so I'd
Immi> like to know what you exactly would think would be useful to
Immi> have:
ok, before you move forward. Today I have been reviewing a PDF using
your branch. So far, it seems ok. But I am not exactly sure what the
difference is. Note that I am simply annotating, so I am not writing a
lot.
I think what we need is two example PDFs (one with and one without) the
patch where you demonstrate us what your code is doing.
So let us talk first about the change of the line endings. Let us ignore
the optimization for a bit.
Correct me if I am wrong. From the description you sent us, what your
patch is doing is taking the "tips" of the line and instead of
varying their width according to the pressure of the pen, you replace
them with a trapezoid? Why don't you create a simple xoj file that
visually shows us your algorithm?
And then you can describe how you are implementing it in xournal.
Is it possible to enable/disable this feature dynamically? My feeling is
that the last thing we want to do is modify the line itself (a line is a
line). This seems to be a "presentation" of the line. Hence the lines
should be saved as lines, but with an option that says: "trapezoidize"
the line ending.
But the real problem is that we _need_ to make sure your patch generates
files that are backwards compatible with xournal. We need to find a way
to do this.
1. "Trapezoidize" the lines after they have been read. The xournal file can
store this as an option, and do this dynamically.
2. Have an option that saves trapezoidizes the lines. user should be
able to enable disable this feature. I can help you do this.
--
Daniel M. German "We need [news] editorial more than ever"
Steve Jobs
http://turingmachine.org/
http://silvernegative.com/
dmg (at) uvic (dot) ca
replace (at) with @ and (dot) with .
------------------------------------------------------------------------------
_______________________________________________
Xournal-devel mailing list
Xournal-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xournal-devel
