Alan Coopersmith wrote:
> Looks like you included libraries & fonts as well as clients in this set.
>   

   Goofed up again! I wanted to diff just the app tree but mistake.
   There are still some cleanups needed to be done for the other
   components.

> XW_NV/open-src/Makefile:
>       data/xcursor-themes is already in the data/Makefile
>       (it was added in nv_74)
>
>       Why are you adding xkbdata?   Can't you just use
>       SUNWxorg-xkb from the g11n consolidation?
>   

   Okay.

> XW_NV/open-src/app/Makefile:
>       app/bdftopcf was already in the open-src/Makefile (since
>       in the full Solaris builds, we need it before building
>       the closed source bits)
>
>       xcursorgen should also already be in open-src/app/Makefile
>       from the nv_74 integrations
>   

   Yes these diffs will go.

>       
> XW_NV/open-src/common/Makefile.inc:
>
>       I'm not clear what you're doing here - are you forcing x11
>       to appear in the pkgconfig files?   Why?
>   

   I faced a build problem that I can't recall right now, but will
   reproduce it and provide more detail.

> XW_NV/open-src/lib/mesa/Makefile:
>
>       Have you checked the glut license?   We never shipped it
>       since the license forbids any modifications, not even
>       bug fixes.   (If we shipped any glut library, it would
>       probably be something like freeglut to avoid this issue.)
>   

  Okay will change to freeglut.

> XW_NV/open-src/xserver/xorg/Makefile:
>
>       Why are you removing the Trusted Extensions patch?
>   

   This should actually be configurable. I am building on a system
   that does not have the Nevada X11 packages to verify that FOX
   is self-hosting. Building Xtsol is dependent on some components
   that are not open so the build fails. So I commented this to get
   the build to succeed.

   The application of this patch and building Xtsol should be
   configurable.

> XW_NV/packages/SUNWfontconfig/prototype:
>
>       Why did you make fc-match a dual 32-bit/64-bit program?
>   

   Mistake during a recent merge. I changed it.

> XW_NV/packages/SUNWxorg-client-docs/prototype:
>
>       Why did you remove the glxgears & glxinfo man pages?
>   

   For some mysterious reason the man files do not get copied
   over to the proto area do package generation fails. I will have
   to investigate this further.

   removed this in my environment just to get the packages to
   build, these are not critical files anyway.

> XW_NV/packages/SUNWxscreensaver-hacks/prototype:
>
>       flying-toasters was not being shipped to having to ask
>       the lawyers about the trademark issues.
>
>       sonar was not being shipped since it only runs if you
>       make it setuid root
>   

   Removed these.

>       
> buildit:
>
>       Why did you remove -k from the make command?
>
>   

   -k will continue with the build even if one module fails. I
   want the build to stop on a failure. This is just for my
   development environment. I am not going to commit this
   change.

Regards,
Moinak.

>   


Reply via email to