[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645844#comment-15645844
]
Wangda Tan commented on YARN-5761:
----------------------------------
Thanks [~xgong], overall approach looks good, some comments:
1) SchedulerQueueContext -> SchedulerQueueManager?
2) Should we push the reinitializeQueue to the base class? With that, YARN-5734
can call the reintializeQueue first for different schedulers. But not sure how
to make the method signature more generalized.
3) Not entirely sure if this works under FS's picture. [~kasha] or [~asuresh],
could you take a look at this patch?
[~sunilg] could you take a look at the patch as well?
> Separate QueueManager from Scheduler
> ------------------------------------
>
> Key: YARN-5761
> URL: https://issues.apache.org/jira/browse/YARN-5761
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacityscheduler
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Labels: oct16-medium
> Attachments: YARN-5761.1.patch, YARN-5761.1.rebase.patch,
> YARN-5761.2.patch
>
>
> Currently, in scheduler code, we are doing queue manager and scheduling work.
> We'd better separate the queue manager out of scheduler logic. In that case,
> it would be much easier and safer to extend.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
