[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655868#comment-15655868
]
Jonathan Hung commented on YARN-5761:
-------------------------------------
This looks good, a few comments:
# We can probably put the {{static QueueHook}} class in
CapacitySchedulerQueueManager
# Can we set the YarnAuthorizationProvider in the CSQueueManager instead of in
CS? Since at least for now this is a queue-level component.
# Can we move the queue label stuff to CSQueueManager as well? i.e.
{{labelManager.reinitializeQueueLabels(getQueueToLabels())}} in
CS#initializeQueues and CS#reinitializeQueues, we can move to the respective
methods in CSQueueManager. So we can pass the labelManager to CSQueueManager in
the constructor, and have getQueueToLabels be a method in CSQueueManager.
# There are calls to {{CS#getQueue}} in some places inside CS, and some calls
to queueManager.getQueue, perhaps we should make them all the same (we can use
CS#getQueue since it is a wrapper around queueManager.getQueue)
# Two other methods, {{getDefaultPriorityForQueue}}, {{getAndCheckLeafQueue}}
maybe consider moving to CSQueueManager. I'm not so sure about
getDefaultPriorityForQueue, since CSQueueManager does queue configuration, does
it make sense to have queue attribute accessors such as
getDefaultPriorityForQueue in CSQueueManager too?
> Separate QueueManager from Scheduler
> ------------------------------------
>
> Key: YARN-5761
> URL: https://issues.apache.org/jira/browse/YARN-5761
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacityscheduler
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Labels: oct16-medium
> Attachments: YARN-5761.1.patch, YARN-5761.1.rebase.patch,
> YARN-5761.2.patch, YARN-5761.3.patch
>
>
> Currently, in scheduler code, we are doing queue manager and scheduling work.
> We'd better separate the queue manager out of scheduler logic. In that case,
> it would be much easier and safer to extend.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
