[
https://issues.apache.org/jira/browse/YARN-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13688446#comment-13688446
]
Hitesh Shah commented on YARN-727:
----------------------------------
Comments:
ResourceMgrDelegate.java:
- In getAllJobs(), why is this not matching against only the MAPREDUCE
application type?
- Why does ResourceMgrDelegate extent YarnClient? I dont believe it should.
Could you file a jira for this.
yarn_service_protos.proto:
- please look at the coding conventions followed in this file - its lowercase
with _ separators
ApplicationCLI.java:
- code should use Option instance for "appTypes" and not rely on parsing the
string. Let the GnuParser do it.
- Look to making use of Option.setValueSeparator, and Option.getValues
- Current code seems like using "--list --foobar=type1,type2" will work.
Does the webservice also handle multiple app types or does that need to be
changed too?
> ClientRMProtocol.getAllApplications should accept ApplicationType as a
> parameter
> --------------------------------------------------------------------------------
>
> Key: YARN-727
> URL: https://issues.apache.org/jira/browse/YARN-727
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 2.1.0-beta
> Reporter: Siddharth Seth
> Assignee: Xuan Gong
> Attachments: YARN-727.10.patch, YARN-727.11.patch, YARN-727.12.patch,
> YARN-727.13.patch, YARN-727.14.patch, YARN-727.1.patch, YARN-727.2.patch,
> YARN-727.3.patch, YARN-727.4.patch, YARN-727.5.patch, YARN-727.6.patch,
> YARN-727.7.patch, YARN-727.8.patch, YARN-727.9.patch
>
>
> Now that an ApplicationType is registered on ApplicationSubmission,
> getAllApplications should be able to use this string to query for a specific
> application type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
