[
https://issues.apache.org/jira/browse/YARN-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13689994#comment-13689994
]
Hitesh Shah commented on YARN-727:
----------------------------------
[~xgong] Thanks for being patient with the reviews. This patch mostly looks
good - getting close to a final one.
Some comments based on offline feedback from [~vinodkv] assuming this can still
go into branch-2.1:
- Change GetAllApplicationsRequest to GetApplicationsRequest.
- Introduce a helper empty constructor - public static GetApplicationsRequest
newInstance()
- YarnClient should also provide a getApplicationList() in addition to
getApplicationList(Set<>)
- Why is this "listOpt.setOptionalArg(true);" needed? -list does not take any
args
- Make "appTypes" in ApplicationCLI a final static field?
- Description of -list and -appTypes duplicates information about comma
separated list.
- How about appTypeOpt.setArgName("Comma-separated application types") to
help aid usage guide?
> ClientRMProtocol.getAllApplications should accept ApplicationType as a
> parameter
> --------------------------------------------------------------------------------
>
> Key: YARN-727
> URL: https://issues.apache.org/jira/browse/YARN-727
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 2.1.0-beta
> Reporter: Siddharth Seth
> Assignee: Xuan Gong
> Attachments: YARN-727.10.patch, YARN-727.11.patch, YARN-727.12.patch,
> YARN-727.13.patch, YARN-727.14.patch, YARN-727.15.patch, YARN-727.16.patch,
> YARN-727.1.patch, YARN-727.2.patch, YARN-727.3.patch, YARN-727.4.patch,
> YARN-727.5.patch, YARN-727.6.patch, YARN-727.7.patch, YARN-727.8.patch,
> YARN-727.9.patch
>
>
> Now that an ApplicationType is registered on ApplicationSubmission,
> getAllApplications should be able to use this string to query for a specific
> application type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
