[
https://issues.apache.org/jira/browse/YARN-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13689645#comment-13689645
]
Hitesh Shah commented on YARN-727:
----------------------------------
Comments:
ResourceMgrDelegate.java:
- Set<String> appTypes = new HashSet<String>(); --> maybe use size 1 as there
will only be one entry or use a more appropriate set collection?
ApplicationCLI.java:
- "list_opt = new Option(LIST_CMD, true" and appType_opt = new
Option("appTypes", false,
- please follow camelCase coding conventions
- why does listOpt take in an argument but appTypeOpt does not? Should it
not be the other way around?
- usage documentation
- for app types, please clearly mention comma-separated list of
application types
- might be good to cut down the text if possible to be a bit more brief
- appType_opt.setArgs(Option.UNLIMITED_VALUES);
- is there a reason to set this? What happens if this is not set?
- "--appTypes=YARN" can be replaced with "--appTypes YARN"
- Can you also add a test to verify that comma separated lists also work
i.e. something like ", YARN, ,,, FOO-YARN ,"
> ClientRMProtocol.getAllApplications should accept ApplicationType as a
> parameter
> --------------------------------------------------------------------------------
>
> Key: YARN-727
> URL: https://issues.apache.org/jira/browse/YARN-727
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 2.1.0-beta
> Reporter: Siddharth Seth
> Assignee: Xuan Gong
> Attachments: YARN-727.10.patch, YARN-727.11.patch, YARN-727.12.patch,
> YARN-727.13.patch, YARN-727.14.patch, YARN-727.15.patch, YARN-727.1.patch,
> YARN-727.2.patch, YARN-727.3.patch, YARN-727.4.patch, YARN-727.5.patch,
> YARN-727.6.patch, YARN-727.7.patch, YARN-727.8.patch, YARN-727.9.patch
>
>
> Now that an ApplicationType is registered on ApplicationSubmission,
> getAllApplications should be able to use this string to query for a specific
> application type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
