[
https://issues.apache.org/jira/browse/YARN-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13689849#comment-13689849
]
Hitesh Shah commented on YARN-791:
----------------------------------
[~sandyr], [~tucu00], [~vinodkv] - sorry for the late comment on this.
I have a slightly different proposal:
- The protobuf layer enforces no defaults.
- It will support the full flexibility and allow users to extract whatever
information they need.
- Not supplying a state will return all nodes
- The user-facing layers are the command line and the UI.
- The UI should not change to return all nodes but just use the apis as
needed to display default behavior i.e. running/healthy nodes only.
- I would like to recommend that the command line be changed to return all
nodes too ( with a different option to get only healthy nodes ). However, I am
ok with the command line remaining as is today with additional options to get
all nodes with better filtering support.
- From the java api and webservices point of view:
- I propose that these confirm to the same standards as the protobuf layer
- Passing nothing to the api will return all nodes.
- A helper function as Vinod mentioned to allow for default behavior
could be added as needed to construct a request that will return only healthy
nodes.
- From the webservices point of view, we could follow the model that
/nodes/ returns all nodes, /nodes/healthy returns healthy ones ... (
nodes?states=.... could be used as needed to get both healthy and new nodes )
- This implies we do not need to introduce something like a "*" state
like /nodes/*/ to address getting all nodes.
We seem to have made quite a few changes for 2.1.0. Instead of trying to
address default behavior and handle default running vs * in various ways, does
it make sense to change the behavior as mentioned above?
> Ensure that RM RPC APIs that return nodes are consistent with /nodes REST API
> -----------------------------------------------------------------------------
>
> Key: YARN-791
> URL: https://issues.apache.org/jira/browse/YARN-791
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: api, resourcemanager
> Affects Versions: 2.0.4-alpha
> Reporter: Sandy Ryza
> Assignee: Sandy Ryza
> Attachments: YARN-791-1.patch, YARN-791-2.patch, YARN-791-3.patch,
> YARN-791-4.patch, YARN-791.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
