[ 
https://issues.apache.org/jira/browse/YARN-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13699328#comment-13699328
 ] 

Vinod Kumar Vavilapalli commented on YARN-791:
----------------------------------------------

Marked it as blocker, let's do this.

Sorry for all the wavering, +1 to Hitesh's proposal.

bq. I would like to recommend that the command line be changed to return all 
nodes too ( with a different option to get only healthy nodes ). However, I am 
ok with the command line remaining as is today with additional options to get 
all nodes with better filtering support.
Let's leave the command line as is with additional filtering support.

bq. The HTTP API would be <URL>[?filter=STATE+]. if filter= param is not 
specified means ALL. if filter= param is specified and it is empty or invalid 
we return an ERROR response.
bq. The change of param name from state to filter seems also a bit more correct 
and self explanatory.
This will not be future proof if and when we want to add filters based on other 
properties. I'd go with 'state' to be explicit.
                
> Ensure that RM RPC APIs that return nodes are consistent with /nodes REST API
> -----------------------------------------------------------------------------
>
>                 Key: YARN-791
>                 URL: https://issues.apache.org/jira/browse/YARN-791
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, resourcemanager
>    Affects Versions: 2.0.4-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>            Priority: Blocker
>         Attachments: YARN-791-1.patch, YARN-791-2.patch, YARN-791-3.patch, 
> YARN-791-4.patch, YARN-791-5.patch, YARN-791-6.patch, YARN-791.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to