[ 
https://issues.apache.org/jira/browse/YARN-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13689874#comment-13689874
 ] 

Alejandro Abdelnur commented on YARN-791:
-----------------------------------------

I prefer Hitesh's suggestion that if you don't specify a filter you get 
everything, this is more intuitive than an implicit filter.

How about?

The HTTP API would be <URL>[?filter=STATE+]. if filter= param is not specified 
means ALL. if filter= param is specified and it is empty or invalid we return 
an ERROR response.
The ProtoBuffer would have a filter list. if the list is empty means ALL.
The Java API would have a newInstance() which means ALL.
The Java API would have a newInstance(EnumSet<State> filter). NULL & 
EnumSet.NONE would throw an IllegalArgumentException. EnumSet.ALL is the same 
as newInstance().

The change of param name from state to filter seems also a bit more correct and 
self explanatory.


                
> Ensure that RM RPC APIs that return nodes are consistent with /nodes REST API
> -----------------------------------------------------------------------------
>
>                 Key: YARN-791
>                 URL: https://issues.apache.org/jira/browse/YARN-791
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, resourcemanager
>    Affects Versions: 2.0.4-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-791-1.patch, YARN-791-2.patch, YARN-791-3.patch, 
> YARN-791-4.patch, YARN-791.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to