[
https://issues.apache.org/jira/browse/YARN-5849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15691227#comment-15691227
]
Daniel Templeton commented on YARN-5849:
----------------------------------------
While we wait for [~bibinchundatt] to review the latest patch, I have a few
minor comments:
* Thanks for fixing the javadocs!
* In {{CGroupsHandler}}, let's leave the {{MTAB_FILE}} constant there for use
in the new constructor.
* The new constructor needs javadocs.
* Looks to me like {{getErrorWithDetails()}} should just return the {{String}}.
* In {{getErrorWithDetails()}} you may want to use
{{UserGroupInformation.getCurrentUser()}} instead of the system property.
* Missing a {{@param}} in the javadoc for
{{testPreMountedControllerInitialization()}}
* It would be good to have messages in all your asserts.
* In the docs, it would be good to be clearer about the new behavior, e.g. that
the mount point will be created if it doesn't exist, that it needs write
permissions, etc. Basically a brain dump to help the poor admin who's trying
to debug a broken cluster.
* Does {{yarn-defaults.xml}} also need to be updated?
> Automatically create YARN control group for pre-mounted cgroups
> ---------------------------------------------------------------
>
> Key: YARN-5849
> URL: https://issues.apache.org/jira/browse/YARN-5849
> Project: Hadoop YARN
> Issue Type: Improvement
> Affects Versions: 2.7.3, 3.0.0-alpha1, 3.0.0-alpha2
> Reporter: Miklos Szegedi
> Assignee: Miklos Szegedi
> Priority: Minor
> Attachments: YARN-5849.000.patch, YARN-5849.001.patch,
> YARN-5849.002.patch, YARN-5849.003.patch
>
>
> Yarn can be launched with linux-container-executor.cgroups.mount set to
> false. It will search for the cgroup mount paths set up by the administrator
> parsing the /etc/mtab file. You can also specify
> resource.percentage-physical-cpu-limit to limit the CPU resources assigned to
> containers.
> linux-container-executor.cgroups.hierarchy is the root of the settings of all
> YARN containers. If this is specified but not created YARN will fail at
> startup:
> Caused by: java.io.FileNotFoundException:
> /cgroups/cpu/hadoop-yarn/cpu.cfs_period_us (Permission denied)
> org.apache.hadoop.yarn.server.nodemanager.util.CgroupsLCEResourcesHandler.updateCgroup(CgroupsLCEResourcesHandler.java:263)
> This JIRA is about automatically creating YARN control group in the case
> above. It reduces the cost of administration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
