[ 
https://issues.apache.org/jira/browse/YARN-5988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15735059#comment-15735059
 ] 

Rohith Sharma K S commented on YARN-5988:
-----------------------------------------

thanks Ajith for the patch.. Approach looks fine to me. 
some comments on the patch, 
# the below code is not required since refresh is done at the serviceStart of 
services.
{noformat}
try {
349           refreshActiveServicesAcls();
350         } catch (YarnException e) {
351           LOG.error("RefreshAll failed so firing fatal event", e);
352           rmContext
353               .getDispatcher()
354               .getEventHandler()
355               .handle(
356                   new 
RMFatalEvent(RMFatalEventType.TRANSITION_TO_ACTIVE_FAILED,
357                       e));
358           throw new ServiceFailedException(
359               "Error on refreshAll during transition to Active", e);
360         }
{noformat}
# Add a test case.

> RM unable to start in secure setup
> ----------------------------------
>
>                 Key: YARN-5988
>                 URL: https://issues.apache.org/jira/browse/YARN-5988
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.9.0, 3.0.0-alpha1
>            Reporter: Ajith S
>            Assignee: Ajith S
>            Priority: Blocker
>         Attachments: YARN-5988.01.patch
>
>
> When CommonConfigurationKeysPublic.HADOOP_SECURITY_AUTHORIZATION=true
> RM is unable to start



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to