[
https://issues.apache.org/jira/browse/YARN-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15807836#comment-15807836
]
Rohith Sharma K S commented on YARN-6064:
-----------------------------------------
Thanks [~varun_saxena] for review..
bq. We are querying flow context while querying flow apps. Is extra peek in app
to flow table required ? Cant we supply flow run ID as well from client ?
Yes, it is required to get flowRunId of application in paginated mode. While
querying flow apps, flowRunId will not be known even in the ApplicationEntity
directly. Though flowRunId is there in UID, it will be a overhead for user to
parse UID and get flowRunId. It will be more user friendly to get it from back
end and get next set of entities.
bq. I think the tests require APPLICATION_CREATED_EVENT to be passed for an
entry in app to flow table to be made. We are relying on it in code.
will wait for Jenkins
bq. Are changes in GenericEntityReader required ?
Yes required. It is an optimization for generic entities when fromId is not
specified(default).
bq. Then from UI side you will send fromId as app91 or you expect at the client
side to find out the next app as app90 and query ? Or client needs to drop the
extra record ? We need to make this clear in the documentation whenever we
write it.
UI will send last entityId i.e app91. So, on next page entities displayed are
app91 to app82. And to the client, it is impossible(not ideal also) to guess
next appId. For last page, always 1 entities(same as fromId) will be retrieved
which indicates that there is no more entities left to retrieve. This is how
Tez has implemented UI. In the document, it is said that including specified Id
which is clear to user that specified will also be appear in next batch.
> Support fromId for flowRuns and flow/flowRun apps REST API's
> ------------------------------------------------------------
>
> Key: YARN-6064
> URL: https://issues.apache.org/jira/browse/YARN-6064
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelinereader
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Labels: yarn-5355-merge-blocker
> Attachments: YARN-6064-YARN-5355.0001.patch
>
>
> Splitting out JIRA YARN-6027 for pagination support for flowRuns, flow apps
> and flow run apps.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
