[ 
https://issues.apache.org/jira/browse/YARN-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15815647#comment-15815647
 ] 

Varun Saxena commented on YARN-6064:
------------------------------------

I have a couple of comments.

# In getFlowRuns call if fromId is not a long, it will throw a 
NumberFormatException and the message generated will not indicate to end user 
that fromId may have been incorrect.
{code}
    } catch (Exception e) {
      handleException(e, url, startTime, "createdTime start/end or limit");
    }
{code}
# The description of fromId in javadoc seems a little ambiguous. What do we 
mean by next set of earlier entities ?

By the way, if we can pass the UID itself, we can bypass extra app to flow 
query.

> Support fromId for flowRuns and flow/flowRun apps REST API's
> ------------------------------------------------------------
>
>                 Key: YARN-6064
>                 URL: https://issues.apache.org/jira/browse/YARN-6064
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelinereader
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>              Labels: yarn-5355-merge-blocker
>         Attachments: YARN-6064-YARN-5355.0001.patch, 
> YARN-6064-YARN-5355.0002.patch, YARN-6064-YARN-5355.0003.patch
>
>
> Splitting out JIRA YARN-6027 for pagination support for flowRuns, flow apps 
> and flow run apps. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to