[
https://issues.apache.org/jira/browse/YARN-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15812379#comment-15812379
]
Sangjin Lee commented on YARN-6064:
-----------------------------------
Thanks [~rohithsharma] for the patch!
(ApplicationRowKeyPrefix.java)
- I'm not sure if this change is necessary. By providing the app id, we're
specifying a complete row key, not a partial prefix. And I think adding this
constructor for the prefix makes things somewhat confusing. We should simply
use the {{ApplicationRowKey}} instance instead to handle the fromId.
(ApplicationEntityReader.java)
- as mentioned above, for the start row let's use something like this:
{code}
ApplicationRowKey startRow = new ApplicationRowKey(
context.getClusterId(), context.getUserId(), context.getFlowName(),
flowRunId, getFilters().getFromId());
// set start row
scan.setStartRow(startRow.getRowKey());
{code}
(FlowRunRowKeyPrefix.java)
- the same comment applies here
(FlowRunEntityReader.java)
- the same comment applies here
In addition, I think many of the checkstyle, javadoc, and whitespace issues are
actionable and easy to fix, including the following:
{noformat}
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServicesHBaseStorage.java:1005:
verifyFlowEntites(client, uri, 3, new int[] { 3, 2, 1 },:52: '{' is
followed by whitespace.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServicesHBaseStorage.java:1006:
new String[] { "flow1", "flow_name", "flow_name2" });:25: '{' is
followed by whitespace.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServicesHBaseStorage.java:1011:
verifyFlowEntites(client, uri, 3, new int[] { 3, 2, 1 },:52: '{' is
followed by whitespace.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServicesHBaseStorage.java:1012:
new String[] { "flow1", "flow_name", "flow_name2" });:25: '{' is
followed by whitespace.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServicesHBaseStorage.java:1016:
verifyFlowEntites(client, uri, 1, new int[] { 3 },:52: '{' is followed by
whitespace.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServicesHBaseStorage.java:1017:
new String[] { "flow1" });:25: '{' is followed by whitespace.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServicesHBaseStorage.java:1027:
verifyFlowEntites(client, uri, 3, new int[] { 3, 2, 1 },:52: '{' is
followed by whitespace.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServicesHBaseStorage.java:1028:
new String[] { "flow1", "flow_name", "flow_name2" });:25: '{' is
followed by whitespace.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServicesHBaseStorage.java:1038:
verifyFlowEntites(client, uri, 3, new int[] { 3, 2, 1 },:52: '{' is
followed by whitespace.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServicesHBaseStorage.java:1039:
new String[] { "flow1", "flow_name", "flow_name2" });:25: '{' is
followed by whitespace.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServicesHBaseStorage.java:1044:
verifyFlowEntites(client, uri, 3, new int[] { 3, 2, 1 },:52: '{' is
followed by whitespace.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServicesHBaseStorage.java:1045:
new String[] { "flow1", "flow_name", "flow_name2" });:25: '{' is
followed by whitespace.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServicesHBaseStorage.java:2280:
int a[], String[] flowsInSequence) throws Exception {:12: Array brackets
at illegal position.
[WARNING]
/testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/reader/TimelineReaderWebServices.java:1262:
warning: no @param for fromId
{noformat}
Could you kindly fix them too?
> Support fromId for flowRuns and flow/flowRun apps REST API's
> ------------------------------------------------------------
>
> Key: YARN-6064
> URL: https://issues.apache.org/jira/browse/YARN-6064
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelinereader
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Labels: yarn-5355-merge-blocker
> Attachments: YARN-6064-YARN-5355.0001.patch,
> YARN-6064-YARN-5355.0002.patch
>
>
> Splitting out JIRA YARN-6027 for pagination support for flowRuns, flow apps
> and flow run apps.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
