[
https://issues.apache.org/jira/browse/YARN-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892530#comment-15892530
]
Varun Saxena commented on YARN-6256:
------------------------------------
Thanks [~rohithsharma] for the patch. This should be quite straightforward
considering it follows similar approach as YARN-6027.
Code wise in general it looks fine.
I am in agreement with removing fromIdPrefix filter as I do not see a concrete
use case for fetching entities by fromIdPrefix.
Few minor comments.
# TimelineEntityFilters class javadoc no longer needs to have javadoc for
fromIdPrefix. Also fromId javadoc needs to be changed appropriately.
# In the javadoc over FlowRunRowKey#getRowKeyAsString we mention its inverted
flow run id. It is infact the correct flow run id.
# For javadocs over getRowKeyAsString methods in *RowKey classes, I would
rather say "Given the encoded row key as string" instead of "Given the raw row
key as string".
# Test failures are related.
# Most of the checkstyle issues can be handled as well
> Add FROM_ID info key for timeline entities in reader response.
> ---------------------------------------------------------------
>
> Key: YARN-6256
> URL: https://issues.apache.org/jira/browse/YARN-6256
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Labels: yarn-5355-merge-blocker
> Attachments: YARN-6256-YARN-5355.0001.patch
>
>
> It is continuation with YARN-6027 to add FROM_ID key in all other timeline
> entity responses which includes
> # Flow run entity response.
> # Application entity response
> # Generic timeline entity response - Here we need to retrospect on idprefix
> filter which is now separately provided.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
