[ 
https://issues.apache.org/jira/browse/YARN-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895703#comment-15895703
 ] 

Varun Saxena commented on YARN-6256:
------------------------------------

I am fine with what has been done in the current patch.
I dont think there was a very strong reason for what was done in YARN-4237. Its 
just that we can get flow run id for single entity read from context and for 
multiple entities we need to get it after parsing row key.
But as parsing of row key is a trivial operation, its fine to parse it at all 
times.

> Add FROM_ID info key for timeline entities in reader response. 
> ---------------------------------------------------------------
>
>                 Key: YARN-6256
>                 URL: https://issues.apache.org/jira/browse/YARN-6256
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>              Labels: yarn-5355-merge-blocker
>         Attachments: YARN-6256-YARN-5355.0001.patch, 
> YARN-6256-YARN-5355.0002.patch
>
>
> It is continuation with YARN-6027 to add FROM_ID key in all other timeline 
> entity responses which includes
> # Flow run entity response. 
> # Application entity response
> # Generic timeline entity response - Here we need to retrospect on idprefix 
> filter which is now separately provided. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to