[
https://issues.apache.org/jira/browse/YARN-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895239#comment-15895239
]
Sangjin Lee commented on YARN-6256:
-----------------------------------
(TimelineReaderWebServices.java)
- l.270: need a space between "fromId." and "fromId" (the same for a few other
places in this file)
(FlowRunEntityReader.java)
- l.257: I thought the check for single entity read was intentional (I guess
this was introduced by YARN-4237). Do we no longer need it? cc [~varun_saxena]
One high level question. How would the UI use the fromId to render itself? For
example, if you ask for 50 entities for the first page, UI would pick the last
(50th) in that set for the fromId for the next page, right? But if you specify
that as the fromId, that entity is returned again in the next call because the
fromId is inclusive, right? Then how does UI deal with that? Does it ask for 51
entities in the next page and drop the first (redundant) one? Am I
misunderstanding this? Is making it precise (e.g. making fromId exclusive)
feasible?
> Add FROM_ID info key for timeline entities in reader response.
> ---------------------------------------------------------------
>
> Key: YARN-6256
> URL: https://issues.apache.org/jira/browse/YARN-6256
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Labels: yarn-5355-merge-blocker
> Attachments: YARN-6256-YARN-5355.0001.patch,
> YARN-6256-YARN-5355.0002.patch
>
>
> It is continuation with YARN-6027 to add FROM_ID key in all other timeline
> entity responses which includes
> # Flow run entity response.
> # Application entity response
> # Generic timeline entity response - Here we need to retrospect on idprefix
> filter which is now separately provided.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
