[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044961#comment-16044961
]
Karthik Kambatla commented on YARN-6670:
----------------------------------------
Thanks for updating the patch, Haibo. Looks mostly good. Some minor comments:
# yarn-default.xml:
## the description still mentions 0 being the default, while the value is -1
## the cpu description is missing the default value. I think a line was missed
while copy-pasting the description
# ResourceThresholds: The newInstance method that takes a single value should
call the other one
# Just an observation. Now, preemptionThreshold takes a single value for all
resources. And, a subsequent JIRA will add resource-specific values for it.
> Add separate NM overallocation thresholds for cpu and memory
> ------------------------------------------------------------
>
> Key: YARN-6670
> URL: https://issues.apache.org/jira/browse/YARN-6670
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Affects Versions: 3.0.0-alpha3
> Reporter: Haibo Chen
> Assignee: Haibo Chen
> Attachments: YARN-6670-YARN-1011.00.patch,
> YARN-6670-YARN-1011.01.patch, YARN-6670-YARN-1011.02.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
