[
https://issues.apache.org/jira/browse/YARN-6610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127533#comment-16127533
]
Daniel Templeton commented on YARN-6610:
----------------------------------------
I would expect a small performance dip, because the code is now doing the right
thing rather than the inexpensive thing. Without this patch the code is fast
but wrong. I'll keep thinking about a way to do this faster, but I'm not sure
there's much more that can be squeezed out. Maybe a cheaper sort like radix
would buy us a little. The real answer is to go through capacity scheduler and
evaluate if all of the uses of {{ResourceCalculator}} (mostly via
{{Resources}}) are correct. I just did that for fair scheduler, and there were
many places where it was being misused.
> DominantResourceCalculator.getResourceAsValue() dominant param is no longer
> appropriate
> ---------------------------------------------------------------------------------------
>
> Key: YARN-6610
> URL: https://issues.apache.org/jira/browse/YARN-6610
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: YARN-3926
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
> Priority: Critical
> Attachments: YARN-6610.001.patch, YARN-6610.YARN-3926.002.patch,
> YARN-6610.YARN-3926.003.patch, YARN-6610.YARN-3926.004.patch,
> YARN-6610.YARN-3926.005.patch
>
>
> The {{dominant}} param assumes there are only two resources, i.e. true means
> to compare the dominant, and false means to compare the subordinate. Now
> that there are _n_ resources, this parameter no longer makes sense.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
