[ 
https://issues.apache.org/jira/browse/YARN-6610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127978#comment-16127978
 ] 

Daniel Templeton commented on YARN-6610:
----------------------------------------

My previous comment about performance was assuming that you're testing with 
more than 2 resources.  If you're testing with only 2 resources, then I'd be 
surprised to see much of a difference.  If that's the case, I can take a closer 
look.

> DominantResourceCalculator.getResourceAsValue() dominant param is no longer 
> appropriate
> ---------------------------------------------------------------------------------------
>
>                 Key: YARN-6610
>                 URL: https://issues.apache.org/jira/browse/YARN-6610
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: YARN-3926
>            Reporter: Daniel Templeton
>            Assignee: Daniel Templeton
>            Priority: Critical
>         Attachments: YARN-6610.001.patch, YARN-6610.YARN-3926.002.patch, 
> YARN-6610.YARN-3926.003.patch, YARN-6610.YARN-3926.004.patch, 
> YARN-6610.YARN-3926.005.patch, YARN-6610.YARN-3926.006.patch
>
>
> The {{dominant}} param assumes there are only two resources, i.e. true means 
> to compare the dominant, and false means to compare the subordinate.  Now 
> that there are _n_ resources, this parameter no longer makes sense.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to