[
https://issues.apache.org/jira/browse/YARN-6610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128077#comment-16128077
]
Daniel Templeton commented on YARN-6610:
----------------------------------------
Looking at the diff, before this patch, the code does 2 or 4 passes through the
resources. I suspect 4 is the common case. After this patch, the code does
only 2 passes, but adds two sorts. If you're seeing a notable performance
difference, I would suspect the sorts. If we want to optimize for the case of
only CPU and memory, we can add another code path to {{DRC#compare()}} for it.
> DominantResourceCalculator.getResourceAsValue() dominant param is no longer
> appropriate
> ---------------------------------------------------------------------------------------
>
> Key: YARN-6610
> URL: https://issues.apache.org/jira/browse/YARN-6610
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: YARN-3926
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
> Priority: Critical
> Attachments: YARN-6610.001.patch, YARN-6610.YARN-3926.002.patch,
> YARN-6610.YARN-3926.003.patch, YARN-6610.YARN-3926.004.patch,
> YARN-6610.YARN-3926.005.patch, YARN-6610.YARN-3926.006.patch
>
>
> The {{dominant}} param assumes there are only two resources, i.e. true means
> to compare the dominant, and false means to compare the subordinate. Now
> that there are _n_ resources, this parameter no longer makes sense.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
