[
https://issues.apache.org/jira/browse/YARN-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297395#comment-16297395
]
Konstantinos Karanasos commented on YARN-7669:
----------------------------------------------
Some more comments on this part of the code (in order they appeared in the
patch, not order of importance):
* ApplicationMasterServiceUtils:
** A few changes are not needed (it is just different checkstyle)
** "Add rejected Scheduling *Requests*"
* AllocateResponse: "Add a list of *rejected* scheduling requests to the
allocate response."
* RejectedSchedulingRequest: you can explain in the javadoc in the beginning of
the class what rejection means. Like during scheduling/placement, is it only
because of constraint violation, etc.?
* RejectionReason: explain what each is expected to do. BTW if all our
constraints are soft, why would we have a could_not_place?
* PlacemedSchedulingRequest: explain what the placementAttempt is; also there
is a double instead in a javadoc.
* PlacementAlgorithmOutput: shouldn't the rejectedRequests actually be a list
of RejectedSchedulingRequests?
* I don't see the API for the ConstraintPlacementAlgorithm. I see an init, I
would expect sth like a "place" etc.
* I am not sure I understand what is the purpose of the
SchedulingProposalCollector. The comments don't help either.
* Do we need the SchedulingRequestHandler? Same for SchedulingResponseHandler.
Look like an overkill. Maybe at least keep them as inner classes?
* SchedulingResponse: say in the javadoc what it will be doing and where it
will be used.
> [API] Introduce interfaces for placement constraint processing
> --------------------------------------------------------------
>
> Key: YARN-7669
> URL: https://issues.apache.org/jira/browse/YARN-7669
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: YARN-7669-YARN-6592.001.patch,
> YARN-7669-YARN-6592.002.patch
>
>
> As per discussions in YARN-7612. This JIRA will introduce the generic
> interfaces which will be implemented in YARN-7612
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
