[
https://issues.apache.org/jira/browse/YARN-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297904#comment-16297904
]
Weiwei Yang commented on YARN-7669:
-----------------------------------
Hi [~asuresh]
I've read the design doc of this umbrella and some committed patches. I got
some comments, could you please take a look?
*PlacedSchedulingRequest*
# line 55: #getNodes returns list of node locations and whose size equals to
number of allocation in the scheduling request, why not to propose some more
nodes than asked in case some of them get rejected by scheduler?
*PlacementAlgorithmOutput*
# There is no set or add method for placed/rejected requests in this class.
# It looks like a SchedulingRequest can be either accepted or rejected, if a
request asks for 100 containers and only 1 of them could not be allocated, it
will be just simply rejected?
*RejectionReason*
# What's the purpose of this? Will you handle rejected requests differently
according the reason how it was rejected, or just for prompting a message to
client? If it is former one, I am not sure if it is good to differentiate them,
can we just use one common logic to handle rejected requests, like reschedule?
If it is the latter one, an enum type might not be informative, it might be
better to have more detailed message because it might be rejected for all sorts
of reasons.
Thanks
> [API] Introduce interfaces for placement constraint processing
> --------------------------------------------------------------
>
> Key: YARN-7669
> URL: https://issues.apache.org/jira/browse/YARN-7669
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: YARN-7669-YARN-6592.001.patch,
> YARN-7669-YARN-6592.002.patch
>
>
> As per discussions in YARN-7612. This JIRA will introduce the generic
> interfaces which will be implemented in YARN-7612
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
