[
https://issues.apache.org/jira/browse/YARN-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297855#comment-16297855
]
Arun Suresh commented on YARN-7669:
-----------------------------------
Thanks for the comments [~kkaranasos]. Will update a patch shortly addressing
most of your comments. For the remaining:
bq. PlacementAlgorithmOutput: shouldn't the rejectedRequests actually be a list
of RejectedSchedulingRequests?
So the RejectedSchedulingRequest is a simple wrapper over the SchedulingRequest
with a Reason. It is the job of the Processor to assign a reason. If its the
algorithm that rejected it, it is assign it appropriately, If it the
scheduler#commit that could not allocate the placed request, the processor
would know and will be able to assign the correct Reason.
bq. I don't see the API for the ConstraintPlacementAlgorithm. I see an init, I
would expect sth like a "place" etc.
So the initial version had it. But if you look at the some of the earlier
comments in YARN-7612, think we had discussed this. YARN-7612 will have a
subclass/implementation of this that will have a place method. It is possible
that the per-schedulerrequest version of the Algorithm wont require a place()
menthod.
w.r.t the SchedulingProposalCollector, SchedulingRequestHandler and
SchedulingResponseHandler. Let me see if I can add more in the docs. But as
with the previous comment, it was not there in the initial versions and Wangda
had requested it be added so as to make it more friendly with the
per-schedulerrequest placement implementaion.
I can maybe drop the SchedulingRequestHandler and SchedulingResponseHandler for
the time being.
> [API] Introduce interfaces for placement constraint processing
> --------------------------------------------------------------
>
> Key: YARN-7669
> URL: https://issues.apache.org/jira/browse/YARN-7669
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: YARN-7669-YARN-6592.001.patch,
> YARN-7669-YARN-6592.002.patch
>
>
> As per discussions in YARN-7612. This JIRA will introduce the generic
> interfaces which will be implemented in YARN-7612
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
