[
https://issues.apache.org/jira/browse/YARN-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16298665#comment-16298665
]
Arun Suresh commented on YARN-7669:
-----------------------------------
Thanks for the review [~sunilg]
bq. How ApplicationMasterServiceUtils#addToRejectedSchedulingRequests is
invoked? I could not find a caller or is it a part of some dependent tickets?
I had used it in the original YARN-7612 patch (v005 and v005 patch), but when I
spit that, I kept this method here since it is more of a utility method and
similar to the other existing methods in ApplicationMasterServiceUtil. The
intention was to make the new YARN-7612 easier to review. Do take a look at the
older patches in YARN-7612 to see how it is being used. I shall update
YARN-7612 once this is ready.
bq. AllocateResponse#getRejectedSchedulingRequests gives rejected requests from
previous allocate to current one. But will this info be retained at scheduler
assuming RM restarted between AM heartbeats? Also one more doubt here,
Good point. Did spend some time thinking about that. I was thinking we tackle
that when we get there. Worst case - we just state for the time being that
retries are reset in the event of a failover. Also, this is not public / user
facing - only used internally in the framework / scheduler.
bq. Could RejectionReason also be used in cases like Node Constraints too? Its
also possible that placement could fail may be node constraint also violated on
a node.
It can and should be used for Node constraints as well. As you suggested above,
we can add more enums as and when required. Only thing is, we should return
RejectedSchedulingRequests only if the AM uses SchedulingRequests, not
ResourceRequests.
> [API] Introduce interfaces for placement constraint processing
> --------------------------------------------------------------
>
> Key: YARN-7669
> URL: https://issues.apache.org/jira/browse/YARN-7669
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: YARN-7669-YARN-6592.001.patch,
> YARN-7669-YARN-6592.002.patch, YARN-7669-YARN-6592.003.patch
>
>
> As per discussions in YARN-7612. This JIRA will introduce the generic
> interfaces which will be implemented in YARN-7612
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
