[
https://issues.apache.org/jira/browse/YARN-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319095#comment-16319095
]
Shane Kumpf commented on YARN-7717:
-----------------------------------
{quote}
I think true/false is preferable to 1/0, since it is more readable. However,
because we've shipped releases using 1/0, we should maintain this functionality
for backwards compatibility.
{quote}
I agree. tc also has the issue, so it would be good to fix them both (and makes
sense given the shared code). I didn't see any others at a glance, but might be
worth a review to see if we have other inconsistencies.
> Add configuration consistency for module.enabled and
> docker.privileged-containers.enabled
> -----------------------------------------------------------------------------------------
>
> Key: YARN-7717
> URL: https://issues.apache.org/jira/browse/YARN-7717
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Yesha Vora
> Assignee: Eric Badger
>
> container-executor.cfg has two properties related to dockerization.
> 1) module.enabled = true/false
> 2) docker.privileged-containers.enabled = 1/0
> Here, both property takes different value to enable / disable feature. Module
> enabled take true/false string while docker.privileged-containers.enabled
> takes 1/0 integer value.
> This properties behavior should be consistent. Both properties should have
> true or false string as value to enable or disable feature/
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
