[ 
https://issues.apache.org/jira/browse/YARN-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320826#comment-16320826
 ] 

Eric Badger commented on YARN-7717:
-----------------------------------

[[email protected]], [~eyang], thanks for the comments!

bq. I'm curious if using strcasecmp might give us more flexibility in how users 
define these
Yep, that seems like a good change to make. I'll fix that up

bq. Also, the documentation only refers to 0/1, I think that should be updated 
as well.
Will update that as well

> Add configuration consistency for module.enabled and 
> docker.privileged-containers.enabled
> -----------------------------------------------------------------------------------------
>
>                 Key: YARN-7717
>                 URL: https://issues.apache.org/jira/browse/YARN-7717
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Yesha Vora
>            Assignee: Eric Badger
>         Attachments: YARN-7717.001.patch
>
>
> container-executor.cfg has two properties related to dockerization. 
> 1)  module.enabled = true/false
> 2) docker.privileged-containers.enabled = 1/0
> Here, both property takes different value to enable / disable feature. Module 
> enabled take true/false string while docker.privileged-containers.enabled  
> takes 1/0 integer value. 
> This properties behavior should be consistent. Both properties should have 
> true or false string as value to enable or disable feature/



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to