[
https://issues.apache.org/jira/browse/YARN-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321708#comment-16321708
]
Miklos Szegedi commented on YARN-7717:
--------------------------------------
Thank you for the patch, [~ebadger].
{code}
5 feature.tc.enabled=true
{code}
The default for tc should still be false.
{code}
492 for (itr = file_cmd_vec.begin(); itr != file_cmd_vec.end();
++itr) {
493 memset(buff, 0, buff_len);
494 write_command_file(itr->first);
495 ret = read_config(docker_command_file.c_str(), &cmd_cfg);
496 if (ret != 0) {
497 FAIL();
498 }
499 ret = set_privileged(&cmd_cfg, &container_cfg, buff, buff_len);
500 ASSERT_EQ(0, ret);
497 ASSERT_STREQ(itr->second.c_str(), buff); 501
ASSERT_STREQ(itr->second.c_str(), buff);
502 }
{code}
There is and indentation issue on the last line.
> Add configuration consistency for module.enabled and
> docker.privileged-containers.enabled
> -----------------------------------------------------------------------------------------
>
> Key: YARN-7717
> URL: https://issues.apache.org/jira/browse/YARN-7717
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Yesha Vora
> Assignee: Eric Badger
> Attachments: YARN-7717.001.patch, YARN-7717.002.patch
>
>
> container-executor.cfg has two properties related to dockerization.
> 1) module.enabled = true/false
> 2) docker.privileged-containers.enabled = 1/0
> Here, both property takes different value to enable / disable feature. Module
> enabled take true/false string while docker.privileged-containers.enabled
> takes 1/0 integer value.
> This properties behavior should be consistent. Both properties should have
> true or false string as value to enable or disable feature/
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
