[
https://issues.apache.org/jira/browse/YARN-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322758#comment-16322758
]
Miklos Szegedi commented on YARN-7717:
--------------------------------------
Thank you, [~ebadger] for the updated patch.
{code}
442 if (strcasecmp(enabled_str, "true") == 0) {
443 enabled = 1;
444 } else {
{code}
Should not we check for false as well and not fall back to a number in that
case?
> Add configuration consistency for module.enabled and
> docker.privileged-containers.enabled
> -----------------------------------------------------------------------------------------
>
> Key: YARN-7717
> URL: https://issues.apache.org/jira/browse/YARN-7717
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Yesha Vora
> Assignee: Eric Badger
> Attachments: YARN-7717.001.patch, YARN-7717.002.patch,
> YARN-7717.003.patch
>
>
> container-executor.cfg has two properties related to dockerization.
> 1) module.enabled = true/false
> 2) docker.privileged-containers.enabled = 1/0
> Here, both property takes different value to enable / disable feature. Module
> enabled take true/false string while docker.privileged-containers.enabled
> takes 1/0 integer value.
> This properties behavior should be consistent. Both properties should have
> true or false string as value to enable or disable feature/
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
