[
https://issues.apache.org/jira/browse/YARN-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358195#comment-16358195
]
Bibin A Chundatt commented on YARN-6858:
----------------------------------------
Thank you [[email protected]] for patch
# List<NodeToAttributes> nodesToAttributes is better since intergating Store
and API interfaces
# For writing to FileSytem Store had in mind to use
{{NodesToAttributesMappingRequestPBImpl}}
# IIUC should reduce object coversion over head too.
{code:java}
../patch/YARN-6858-YARN-3409.002.patch:185: trailing whitespace.
../patch/YARN-6858-YARN-3409.002.patch:194: trailing whitespace.
{code}
# Avoid the above whiteSpace error.
# AttributeNodeLabelsManagerImpl correct params
{code:java}
/**
* @param nodeAttributeMappings
* @param newAttributesToBeAdded
* @return Map<String, Map<String, NodeAttribute>>, node -> Map( attributeName
* -> NodeAttribute)
* @throws IOException
*/
protected Map<String, Map<NodeAttribute, AttributeValue>>
validateAndGetNodeToAttribMap(
Map<String, Set<NodeAttribute>> nodeAttributeMapping,
Map<NodeAttribute, RMAttributeNodeLabel> newAttributesToBeAdded,
boolean isRemoveOperation) throws IOException
{code}
# NodeAttributesStoreEvent need to be moved label store events we have added
in common
# AttributeNodeLabelsManager can we have a method to return all NodeAttributes
{code:java}
List<NodeToAttributes> getNodeToAttributes();
{code}
# {{AdminService}} , RMContext , Resource Manager service addition etc need to
be added, I will file a jira to handle wiring part.
> Attribute Manager to store and provide the attributes in RM
> -----------------------------------------------------------
>
> Key: YARN-6858
> URL: https://issues.apache.org/jira/browse/YARN-6858
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: api, capacityscheduler, client
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Priority: Major
> Attachments: YARN-6858-YARN-3409.001.patch,
> YARN-6858-YARN-3409.002.patch
>
>
> Similar to CommonNodeLabelsManager we need to have a centralized manager for
> Node Attributes too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
