Bibin A Chundatt commented on YARN-6858:

Thank you [~naganarasimha...@apache.org]  for patch

 # List<NodeToAttributes> nodesToAttributes is better since intergating Store 
and API interfaces
 # For writing to FileSytem Store had in mind to use 
 # IIUC should reduce object coversion over head too.
../patch/YARN-6858-YARN-3409.002.patch:185: trailing whitespace.
../patch/YARN-6858-YARN-3409.002.patch:194: trailing whitespace.

 # Avoid the above whiteSpace error.
 # AttributeNodeLabelsManagerImpl correct params
   * @param nodeAttributeMappings
   * @param newAttributesToBeAdded
   * @return Map<String, Map<String, NodeAttribute>>, node -> Map( attributeName
   *         -> NodeAttribute)
   * @throws IOException
  protected Map<String, Map<NodeAttribute, AttributeValue>> 
      Map<String, Set<NodeAttribute>> nodeAttributeMapping,
      Map<NodeAttribute, RMAttributeNodeLabel> newAttributesToBeAdded,
      boolean isRemoveOperation) throws IOException

 # NodeAttributesStoreEvent need to be moved label store events we have added 
in common
 # AttributeNodeLabelsManager can we have a method to return all NodeAttributes
List<NodeToAttributes> getNodeToAttributes();

 # {{AdminService}} , RMContext , Resource Manager service addition etc need to 
be added, I will file a jira to handle wiring part.

> Attribute Manager to store and provide the attributes in RM
> -----------------------------------------------------------
>                 Key: YARN-6858
>                 URL: https://issues.apache.org/jira/browse/YARN-6858
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, capacityscheduler, client
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>            Priority: Major
>         Attachments: YARN-6858-YARN-3409.001.patch, 
> YARN-6858-YARN-3409.002.patch
> Similar to CommonNodeLabelsManager we need to have a centralized manager for 
> Node Attributes too.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to