[
https://issues.apache.org/jira/browse/YARN-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360356#comment-16360356
]
Sunil G commented on YARN-6858:
-------------------------------
Thanks [~Naganarasimha] for the patch.
Few comments.
1. {{public abstract Map<NodeAttribute, Set<String>>
getAttributesToNodes(Set<NodeAttribute> attributes);}} returns a map of
attributes to set of nodes. This is something we need to check a bit as
existing api's from node labels found to be a bit tough to use. (recent Ui
works to use REST endpoint and resource types work.) Since this
*getAttributesToNodes* is not used in this patch, could be remove this from the
scope of patch and take to a separate Jira to discuss api more concretely.
2. I found *compare* a bit confusing as it takes the operation also. Many
operations are mutually exclusive in nature and it is contradicting with the
default compare nature of an object.
3. Rename removeNodeFromLabels to removeNodeFromAttributes
4. Is AsyncDispatcher used for store?
> Attribute Manager to store and provide the attributes in RM
> -----------------------------------------------------------
>
> Key: YARN-6858
> URL: https://issues.apache.org/jira/browse/YARN-6858
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: api, capacityscheduler, client
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Priority: Major
> Attachments: YARN-6858-YARN-3409.001.patch,
> YARN-6858-YARN-3409.002.patch, YARN-6858-YARN-3409.003.patch
>
>
> Similar to CommonNodeLabelsManager we need to have a centralized manager for
> Node Attributes too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
