[
https://issues.apache.org/jira/browse/YARN-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360128#comment-16360128
]
Naganarasimha G R commented on YARN-6858:
-----------------------------------------
Thanks Weiwei and Bibin for comments ,
For WEiwei's comments :
* all comments except the 4th one of AttributeNodeLabelsManager are accepted
and reworked upon, but not able to get 4th one may be you were referring to a
older patch
* AttributeNodeLabelsManagerImpl, 1,2,3,5 are accepted and 4 as discussed in
the meeting have addressed by removing the config check
* AttributeNodeLabelsManagerImpl 4th point , as per the discussion i am not
checking for the node labels
* AttributeNodeLabelsManagerImpl line 204: validateAndGetNodeToAttribMap , has
been optimized to check for the cluster level node attribute type is not
getting mismatche, hence was not able to extract it out effectively to be
reused in other places like script based provider. But have made it read able
by extracting it to a method.
* AttributeNodeLabelsManagerImpl 7 & 8 will be discussed and handled in other
jira.
For bibin's comments :
* _List<NodeToAttributes> nodesToAttributes is better than_, with that
intention itself had written the api in 001 patch . But somehow was not
convinced to have api based on particular scenarios and end time while having a
look was not able to understand why the api was not set or map but a list. Did
not want to write the api for the needs of the proto communication, hence
reverted back the api to the current syntax.
* NodesToAttributesMappingRequestPBImpl could be still be used as it will be
processed, only thing is that it needs to be recreated after processing based
on this api. I think we can not avoid it like the labels to keep the interface
clean.
* whiteSpace error.in AttributeValue has been corrected.
* AttributeNodeLabelsManagerImpl correct params--> done
* NodeAttributesStoreEvent is under
"org.apache.hadoop.yarn.server.resourcemanager.nodelabels", may be missed to
understand your comment
* _Map<NodeAttribute, AttributeValue> getAttributesForNode(String hostName)_
is already existing in NodeAttributesManager which has the similar
functionality. I was not able to get a use case for fetching for all nodes, any
reason why and also wanted to avoid manager's api tied up with dao's like
NodeToAttributes. In any case i think its not a blocking issue as discussed
will handle in another jira.
* AdminService service related changes as discussed in the meeting planning to
handle as part of CLI changes for interacting with Manager (2a listed in our
doc) and for other wiring i think its simple and should be available as part of
this jira hence handling it over here itself.
> Attribute Manager to store and provide the attributes in RM
> -----------------------------------------------------------
>
> Key: YARN-6858
> URL: https://issues.apache.org/jira/browse/YARN-6858
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: api, capacityscheduler, client
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Priority: Major
> Attachments: YARN-6858-YARN-3409.001.patch,
> YARN-6858-YARN-3409.002.patch, YARN-6858-YARN-3409.003.patch
>
>
> Similar to CommonNodeLabelsManager we need to have a centralized manager for
> Node Attributes too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
