Naganarasimha G R commented on YARN-6858:

Thanks for the review [~cheersyang] and [~sunilg] 
Sorry for the delay, had to interact with Sunil for his comments.

Have uploaded the patch after clarifying most of the comments offline:
{quote}That says for a given attribute value, we need to check if it is in (or 
not in) a set of strings. In this case, this API doesn't seem to be appropriate.

In case of comparing against multiple set , i am planning to introduce 
Multivalued string Attribute which compares against a StringValueAttribute.
{quote}bq. Basically I think we should have a more restrictive equals 
implementation to avoid confusions.

As discussed if its more restrictive then we need to compare both type and 
value, Main idea is we are identifying a Attribute to be unique if and only 
prefix and name mapping pair are unique. based on the example given there we 
can keep value out the NodeAttribute (in similar lines me and Sunil had 
discussed earlier) but it leads to multiple objects for communication and api, 
I agree we need to keep the api and not dependent on other optimization factors 
but in this case it would complicate the api hence as per discussion with Sunil 
we have gone ahead with the existing approach
{quote}We need an UT for #validate, but I am OK to track this in a lower 
priority Jira

Working on it, hopefully before commit i can update the patch with it else will 
take it as minor jira
{quote}bq. Is AsyncDispatcher used for store?


> Attribute Manager to store and provide the attributes in RM
> -----------------------------------------------------------
>                 Key: YARN-6858
>                 URL: https://issues.apache.org/jira/browse/YARN-6858
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, capacityscheduler, client
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>            Priority: Major
>         Attachments: YARN-6858-YARN-3409.001.patch, 
> YARN-6858-YARN-3409.002.patch, YARN-6858-YARN-3409.003.patch, 
> YARN-6858-YARN-3409.004.patch
> Similar to CommonNodeLabelsManager we need to have a centralized manager for 
> Node Attributes too.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to