[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585329#comment-16585329
]
Naganarasimha G R commented on YARN-7863:
-----------------------------------------
Thanks [~sunilg], for the latest patch,
Some of the things [~cheersyang] mentioned i too had the same issues and had
mentioned in my earlier comment like :
* _PlacementConstraintParser.NodeConstraintParser_ not to store value (had
captured 2nd point) .
* _getConstraintNameWithNameSpace()_ defaults the namespace (had captured 4th
point) .
And seems like many other comments like the following was not addressed or
replied yet:
* I replaced expression @ _TestPlacementConstraintParser ln no 481,_ with
"OR(IN,python=true:NOTIN,java=1.8):IN,os!=centos:NOTIN,env=prod,dev" and i see
exception as "_Invalid constraint expression
OR(IN,python=true:NOTIN,java=1.8)_". IIUC our branch does not support OR
expressions yet, So does it requires a rebase to confirm the same ?
* Distributed shell needs to support both specs for the allocation tags and
attributes, which i believe can only be achieved having AttributeSpec .
Unless we have to seriously meet the deadlines then lets avoid it but if you
already have it ready then why not go for it ?
* TestPlacementConstraintParser ln no 453 : testParseNodeAttributeSpec has
attributeName1, attributeName2; which is unused
* ResourceManager ln no 652-654 createNodeAttributesManager should either
return NodeAttributesManagerImpl or take parameter as rmContext instead of type
casting
* findbugs seems to be existent from the previous patch.
I concur with most of the [~cheersyang]'s comments except
* We need to have a info log or rather an audit to track the attributes being
modified but nevertheless there is both info and a debug log of the same
message @202 and 205 , but 222 can be avoided all together
*TestCases :*
* I would love to have a DistributedShell test case with Node attributes in
the placement Contstraints. As discussed if required we can take the DS changes
from here to a separate patch to make this patch less bulky
* And & OR Expressions in the expressions
* Test case for covering scheduling part of the Placement expression
containing Node Attributes
Shall we have a quick huddle some time this week, so that we can finalize on
these stuff and then go ahead ?
> Modify placement constraints to support node attributes
> -------------------------------------------------------
>
> Key: YARN-7863
> URL: https://issues.apache.org/jira/browse/YARN-7863
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Sunil Govindan
> Assignee: Sunil Govindan
> Priority: Major
> Attachments: YARN-7863-YARN-3409.002.patch,
> YARN-7863-YARN-3409.003.patch, YARN-7863-YARN-3409.004.patch,
> YARN-7863-YARN-3409.005.patch, YARN-7863-YARN-3409.006.patch,
> YARN-7863.v0.patch
>
>
> This Jira will track to *Modify existing placement constraints to support
> node attributes.*
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
