[ https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589075#comment-16589075 ]
Naganarasimha G R commented on YARN-7863: ----------------------------------------- Hi [~sunilg], Now i am confused when we have everything in one single expression . * IIUC we can specify allocation tags, attribute expression and partition label all in single expression ? * If its the case then how are we going select the outstanding/ pending requests for a given queue for a given partition, as there could be OR with allocation tags or attribute expression right ? I think this issue should be already existing when we have OR ing involved with allocation tags ? * Based on the test cases in TestPlacementConstraintParser.testParseNodeAttributeSpec, Allocation tags are created even if we want to specify attribute expression ? ex : "xyz,in,rm.yarn.io/foo=true" xyz is allocation tag ? If so users will be really confused what to pass and what not ! * if i specify "IN" and have attribute expression as "xyz,in,rm.yarn.io/foo{color:#d04437}*!=*{color}true" is it valid ? In future when we come with more operators it would not make sense. I would suggest to go with "," as separator. I am not sure how many cases would be there where we want to specify all the constraints in the same expression but we are making the users life complex with having such a complex DSL. > Modify placement constraints to support node attributes > ------------------------------------------------------- > > Key: YARN-7863 > URL: https://issues.apache.org/jira/browse/YARN-7863 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Sunil Govindan > Assignee: Sunil Govindan > Priority: Major > Attachments: YARN-7863-YARN-3409.002.patch, > YARN-7863-YARN-3409.003.patch, YARN-7863-YARN-3409.004.patch, > YARN-7863-YARN-3409.005.patch, YARN-7863-YARN-3409.006.patch, > YARN-7863-YARN-3409.007.patch, YARN-7863-YARN-3409.008.patch, > YARN-7863.v0.patch > > > This Jira will track to *Modify existing placement constraints to support > node attributes.* -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org