[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589559#comment-16589559
]
Naganarasimha G R commented on YARN-7863:
-----------------------------------------
Hi [~sunilg],
few other nits in the patch :
* NodeAttributesManagerImpl ln no 205: as i was mentioning there is both debug
and info log here ,i think we can remove the debug log.
* NodeAttributesManagerImpl ln no 212-226 : Here you are sending out complete
update of the node collections, and not just the modified NM's only. There are
multiple impacts due to this, in large cluster we are unnecessarily sending lot
of updates to scheduler secondly removed attributes will not be captured in
this way. Where in later is more important
* NodeAttributesManagerImpl ln no 212-226 : In general idea earlier was to
make use of the AttributeValue by the scheduler so that the converted value is
stored and used for comparison . But if we have the flexibility later on to
change the scheduler event which is being pushed from NAM to Schedulers then i
am fine with the Event being sent out, else i would suggest to send the
AttributeValue itself
* Test cases for AND and OR are covered ? Though i could see AND not
declaratively covered in TestPlacementConstraintParser but better to cover with
AND and OR explicitly
* PlacementSpec ln no 51: typo "teh"
> Modify placement constraints to support node attributes
> -------------------------------------------------------
>
> Key: YARN-7863
> URL: https://issues.apache.org/jira/browse/YARN-7863
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Sunil Govindan
> Assignee: Sunil Govindan
> Priority: Major
> Attachments: YARN-7863-YARN-3409.002.patch,
> YARN-7863-YARN-3409.003.patch, YARN-7863-YARN-3409.004.patch,
> YARN-7863-YARN-3409.005.patch, YARN-7863-YARN-3409.006.patch,
> YARN-7863-YARN-3409.007.patch, YARN-7863-YARN-3409.008.patch,
> YARN-7863.v0.patch
>
>
> This Jira will track to *Modify existing placement constraints to support
> node attributes.*
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
