[ 
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589116#comment-16589116
 ] 

Weiwei Yang commented on YARN-7863:
-----------------------------------

Hi [~Naganarasimha]

Regarding some of your comments
{quote}IIUC we can specify allocation tags, attribute expression  and partition 
label all in single expression ?
{quote}
Yes, this is supported. User can specify constraints against allocation tags, 
node attributes and partition in a single expression (a conjunction expression 
composed by AND or OR). E.g place a container on a node has allocation tag X 
and javaVersion (node-attribute)  = 1.8.
{quote}If its the case then how are we going select the outstanding/ pending 
requests for a given queue for a given partition, as there could be OR with 
allocation tags or attribute expression right ? 
{quote}
PC doesn't affect any logic how scheduler selects requests, it is still how it 
is handled now. A PC is simply checked twice when 1) creating an allocation 
proposal on a node and 2) at commit phase against a specific node.
{quote}Allocation tags are created even if we want to specify attribute 
expression ?
{quote}
No, not necessarily. Just to keep the changes clean and incremental, we can 
allow this form for now. Because this is the spec we used for distributed 
shell. Since we don't have an --allocationTags argument. A "foo=3" is the only 
way to specify allocation tags right now. A follow-up task is to make that 
optional. But I am not sure why even a single tag without container number is 
supported, maybe [~sunilg] can comment more.

I want to reinforce the phase-target (for the merge), we want node-attributes 
can be integrated into PC and support simple operation "=" and "!=". We want to 
extend DS to support node-attributes PC expressions for testing, but with 
minimal changes to the existing placement spec. For real users, their interface 
will be java API or native service spec, not this spec in DS.

Hope that makes sense. 

> Modify placement constraints to support node attributes
> -------------------------------------------------------
>
>                 Key: YARN-7863
>                 URL: https://issues.apache.org/jira/browse/YARN-7863
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Sunil Govindan
>            Assignee: Sunil Govindan
>            Priority: Major
>         Attachments: YARN-7863-YARN-3409.002.patch, 
> YARN-7863-YARN-3409.003.patch, YARN-7863-YARN-3409.004.patch, 
> YARN-7863-YARN-3409.005.patch, YARN-7863-YARN-3409.006.patch, 
> YARN-7863-YARN-3409.007.patch, YARN-7863-YARN-3409.008.patch, 
> YARN-7863.v0.patch
>
>
> This Jira will track to *Modify existing placement constraints to support 
> node attributes.*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to