[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13794329#comment-13794329
]
Zhijie Shen commented on YARN-987:
----------------------------------
Do we really need ApplicationHistoryContext? I guess it may be the analog of
HistoryContext of JHS. However, the designs of AHS and JHS are not almost the
same. HistoryContext is necessary because it involves the cache mechanism, not
only mapping the internal objects to the user-friendly objects. We can add the
cache mechanism later, but now I think it's more obvious that in the
implementation of ApplicationHistoryProtocol, we directly map an internal
object into the user-friendly object.
In addition, we've involved the configurations in several patches. Probably,
we'd like to overview them together, to ensure their names are consistent.
One detailed comment: I don't think it's good to reflect the implementation
detail. And if we directly map the history data into GetApplicationsResponse,
we may get rid of the following code.
{code}
+ HashMap<ApplicationId, ApplicationHistoryData> applicationsHistory =
+ (histData instanceof HashMap<?, ?>)
+ ? (HashMap<ApplicationId, ApplicationHistoryData>) histData
+ : new HashMap<ApplicationId, ApplicationHistoryData>(histData);
{code}
> Adding History Service to use Store and converting Historydata to Report
> ------------------------------------------------------------------------
>
> Key: YARN-987
> URL: https://issues.apache.org/jira/browse/YARN-987
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Mayank Bansal
> Assignee: Mayank Bansal
> Attachments: YARN-987-1.patch, YARN-987-2.patch, YARN-987-3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
