[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814743#comment-13814743
]
Mayank Bansal commented on YARN-987:
------------------------------------
Thanks [~vinodkv] and [~zjshen] for the review.
bq. The unnecessary type casting is still there.
Done
bq. lastAttempt can be null. Should do null check. Otherwise, NPE may be
expected.
Done
bq. Is it good to write a test case for this one?
Done
bq. reduce the scope of methods like getLastAttempt, they don't need to be
public.
Done
bq. ApplicationHistoryContext -> ApplicationHistoryManager and
ApplicationHistory -> ApplicationHistoryManagerImpl. They aren't just context
objects.
Done
Thanks,
Mayank
> Adding History Service to use Store and converting Historydata to Report
> ------------------------------------------------------------------------
>
> Key: YARN-987
> URL: https://issues.apache.org/jira/browse/YARN-987
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Mayank Bansal
> Assignee: Mayank Bansal
> Attachments: YARN-987-1.patch, YARN-987-2.patch, YARN-987-3.patch,
> YARN-987-4.patch, YARN-987-5.patch, YARN-987-6.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
