[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814196#comment-13814196
]
Mayank Bansal commented on YARN-987:
------------------------------------
Thanks [~zjshen] for the review.
bq. As we're going to have cache, the abstraction of ApplicationHistoryContext
may be necessary. However, one more question here: webUI and services are going
to use ApplicationHistoryContext as well, right? if they are, returning report
PB is actually not necessary for web. If they're not, webUI and services need a
duplicate abstraction of combining cache and store, which is concise in terms
of coding.
As discussed offline, We should be using History context for both client and
UI, however it has one drawback of using proto objects to UI. Otherwise we need
to have seprate classes for UI which I think duplicate of work.
bq. Add the config to yarn-default.xml as well. Btw, is "store.class" a bit
better, as we have XXXApplicationHistoryStore, not XXXApplicationHistoryStorage?
Done
bq. Unnecessary code. ApplicationHistoryStore must be a service
Done.
bq. Unnecessary code. ApplicationHistoryStore must be a service
Done
bq. For ApplicationReport, you may want to get the history data of its last
application attempt to fill the empty fields bellow.
Done
Thanks,
Mayank
> Adding History Service to use Store and converting Historydata to Report
> ------------------------------------------------------------------------
>
> Key: YARN-987
> URL: https://issues.apache.org/jira/browse/YARN-987
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Mayank Bansal
> Assignee: Mayank Bansal
> Attachments: YARN-987-1.patch, YARN-987-2.patch, YARN-987-3.patch,
> YARN-987-4.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
