[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13810557#comment-13810557
]
Mayank Bansal commented on YARN-987:
------------------------------------
Thanks [~zjshen] for the review.
bq. Do we really need ApplicationHistoryContext? I guess it may be the analog
of HistoryContext of JHS. However, the designs of AHS and JHS are not almost
the same. HistoryContext is necessary because it involves the cache mechanism,
not only mapping the internal objects to the user-friendly objects. We can add
the cache mechanism later, but now I think it's more obvious that in the
implementation of ApplicationHistoryProtocol, we directly map an internal
object into the user-friendly object.
As we discussed offline, Yes thats similar to JHS design and as we decided to
go for Cache implementation I think that makes sense to have clear sepration
between these two.
bq. In addition, we've involved the configurations in several patches.
Probably, we'd like to overview them together, to ensure their names are
consistent.
Done
{code}
+ HashMap<ApplicationId, ApplicationHistoryData> applicationsHistory =
+ (histData instanceof HashMap<?, ?>)
+ ? (HashMap<ApplicationId, ApplicationHistoryData>) histData
+ : new HashMap<ApplicationId, ApplicationHistoryData>(histData);
{code}
I removed this in latest patch.
Thanks,
Mayank
> Adding History Service to use Store and converting Historydata to Report
> ------------------------------------------------------------------------
>
> Key: YARN-987
> URL: https://issues.apache.org/jira/browse/YARN-987
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Mayank Bansal
> Assignee: Mayank Bansal
> Attachments: YARN-987-1.patch, YARN-987-2.patch, YARN-987-3.patch,
> YARN-987-4.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
