[
https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17010710#comment-17010710
]
Eric Payne commented on YARN-9052:
----------------------------------
{quote}I am a little bit concerned with Jiras that solely opened for the
purpose of refactoring and code readability; especially when they have no
impact on bug fixes fix/performance.
{quote}
I somewhat disagree with this point. I do feel that there is a place for code
cleanup JIRAs. There is a lot of tech-debt in Hadoop that would be good to
clean up. This JIRA, for example, addressed a real usability problem with the
old \{{MockRM#submitApp}} method.
{quote}3. Any developer who has a pending patch that includes submitApp() in
new tests cases (i.e., MAPREDUCE-7169) will have to go through his changes one
more time to upload a new patch.
{quote}
{quote}4. This patch creates many conflicts with other branches and complicates
merges going forward. This is a significant amount of man hours to handle the
new patch.
{quote}
Yes, these are concerns of mine as well. Whenever very invasive changes like
these are made, we have to balance any possible benefits against the very real
added effort on backporting and upmerging.
> Replace all MockRM submit method definitions with a builder
> -----------------------------------------------------------
>
> Key: YARN-9052
> URL: https://issues.apache.org/jira/browse/YARN-9052
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments:
> YARN-9052-004withlogs-patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt,
> YARN-9052-testlogs003-justfailed.txt,
> YARN-9052-testlogs003-patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt,
> YARN-9052-testlogs004-justfailed.txt, YARN-9052.001.patch,
> YARN-9052.002.patch, YARN-9052.003.patch, YARN-9052.004.patch,
> YARN-9052.004.withlogs.patch, YARN-9052.005.patch, YARN-9052.006.patch,
> YARN-9052.007.patch, YARN-9052.008.patch, YARN-9052.009.patch,
> YARN-9052.009.patch, YARN-9052.testlogs.002.patch,
> YARN-9052.testlogs.002.patch, YARN-9052.testlogs.003.patch,
> YARN-9052.testlogs.patch
>
>
> MockRM has 31 definitions of submitApp, most of them having more than
> acceptable number of parameters, ranging from 2 to even 22 parameters, which
> makes the code completely unreadable.
> On top of unreadability, it's very hard to follow what RmApp will be produced
> for tests as they often pass a lot of empty / null values as parameters.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
