[
https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17011384#comment-17011384
]
Sunil G commented on YARN-9052:
-------------------------------
MockRM was one of the confused test class in YARN which was used and maintained
very poorly from longer time. I have seen a variation 20+ submitApp calls, and
when i wanted to add a new parameter such app priority or app timeout, it took
more pain to have an additional submitApp call to be written and change 20 +
method signature. I think many of us in the past went through this.
Hence when an effort was made to make this cleaner and more easier to maintain
for future, I was happy to see that. And moreover it was helping for any future
usage of MockRM in a much more cleaner way.
Being said that, there seems to be some short term challenges due to this, and
considering it was for much better purpose, I definitely back to [~ebadger]'s
point here and support such activities. However contributor and committer can
also may communicate the same this mailing lists so that a surprise can be
avoided. And it will reach to all members about such an ongoing activity. And
they can chime in and share the thoughts in such short improvement projects.
Apologising as this step was missed from my side, and will take care of such
things in future.
> Replace all MockRM submit method definitions with a builder
> -----------------------------------------------------------
>
> Key: YARN-9052
> URL: https://issues.apache.org/jira/browse/YARN-9052
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments:
> YARN-9052-004withlogs-patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt,
> YARN-9052-testlogs003-justfailed.txt,
> YARN-9052-testlogs003-patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt,
> YARN-9052-testlogs004-justfailed.txt, YARN-9052.001.patch,
> YARN-9052.002.patch, YARN-9052.003.patch, YARN-9052.004.patch,
> YARN-9052.004.withlogs.patch, YARN-9052.005.patch, YARN-9052.006.patch,
> YARN-9052.007.patch, YARN-9052.008.patch, YARN-9052.009.patch,
> YARN-9052.009.patch, YARN-9052.testlogs.002.patch,
> YARN-9052.testlogs.002.patch, YARN-9052.testlogs.003.patch,
> YARN-9052.testlogs.patch
>
>
> MockRM has 31 definitions of submitApp, most of them having more than
> acceptable number of parameters, ranging from 2 to even 22 parameters, which
> makes the code completely unreadable.
> On top of unreadability, it's very hard to follow what RmApp will be produced
> for tests as they often pass a lot of empty / null values as parameters.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
