[
https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17010779#comment-17010779
]
Ahmed Hussein commented on YARN-9052:
-------------------------------------
{quote}Yes, these are concerns of mine as well. Whenever very invasive changes
like these are made, we have to balance any possible benefits against the very
real added effort on backporting and upmerging.{quote}
[~epayne], I definitely agree with you about considering a balance between the
value added by code cleanup. However, the frequency of code cleanup tickets on
Jira increased recently. The code cleanup Jiras even span consecutive numbers
which is really alarming.
See a sample of the Jiras below.
Also, similar to bug-fixes and features, patches related to code refactoring
should be thoroughly tested which does not seem the case in the history of this
very Jira.
* [YARN-10005: Code improvements in
MutableCSConfigurationProvider|https://issues.apache.org/jira/browse/YARN-10005]
* [YARN-10004: Javadoc of YarnConfigurationStore#initialize is not
straightforward|https://issues.apache.org/jira/browse/YARN-10004]
* [YARN-10002: Code cleanup and improvements
ConfigurationStoreBaseTest|https://issues.apache.org/jira/browse/YARN-10002]
* [YARN-10001: Add explanation of unimplemented methods in
InMemoryConfigurationStore|https://issues.apache.org/jira/browse/YARN-10001]
* [YARN-10000: Code cleanup in
FSSchedulerConfigurationStore|https://issues.apache.org/jira/browse/YARN-10000]
* [YARN-9999: TestFSSchedulerConfigurationStore: Extend from
ConfigurationStoreBaseTest, general code
cleanup|https://issues.apache.org/jira/browse/YARN-9999]
* [YARN-9998: Code cleanup in
LeveldbConfigurationStore|https://issues.apache.org/jira/browse/YARN-9998]
* [YARN-9997: Code cleanup in
ZKConfigurationStore|https://issues.apache.org/jira/browse/YARN-9997]
* [YARN-9996: Code cleanup in
QueueAdminConfigurationMutationACLPolicy|https://issues.apache.org/jira/browse/YARN-9996]
* [YARN-9995: Code cleanup in
TestSchedConfCLI|https://issues.apache.org/jira/browse/YARN-9995]
* [YARN-9989: Typo in CapacityScheduler documentation: Runtime
Configuration|https://issues.apache.org/jira/browse/YARN-9989]
* [YARN-9680: Code cleanup in ResourcePluginManager init
methods|https://issues.apache.org/jira/browse/YARN-9680]
* [YARN-9679: Regular code cleanup in
TestResourcePluginManager|https://issues.apache.org/jira/browse/YARN-9679]
> Replace all MockRM submit method definitions with a builder
> -----------------------------------------------------------
>
> Key: YARN-9052
> URL: https://issues.apache.org/jira/browse/YARN-9052
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments:
> YARN-9052-004withlogs-patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt,
> YARN-9052-testlogs003-justfailed.txt,
> YARN-9052-testlogs003-patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt,
> YARN-9052-testlogs004-justfailed.txt, YARN-9052.001.patch,
> YARN-9052.002.patch, YARN-9052.003.patch, YARN-9052.004.patch,
> YARN-9052.004.withlogs.patch, YARN-9052.005.patch, YARN-9052.006.patch,
> YARN-9052.007.patch, YARN-9052.008.patch, YARN-9052.009.patch,
> YARN-9052.009.patch, YARN-9052.testlogs.002.patch,
> YARN-9052.testlogs.002.patch, YARN-9052.testlogs.003.patch,
> YARN-9052.testlogs.patch
>
>
> MockRM has 31 definitions of submitApp, most of them having more than
> acceptable number of parameters, ranging from 2 to even 22 parameters, which
> makes the code completely unreadable.
> On top of unreadability, it's very hard to follow what RmApp will be produced
> for tests as they often pass a lot of empty / null values as parameters.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
