[
https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012080#comment-17012080
]
Eric Yang commented on YARN-9052:
---------------------------------
Code clean up and performance optimization usually go hand in hand to ensure
the net gain is positive. Some basic level of comprehension presents during
the execution of the code. If code is hard to understand by human, it will run
poorly by machine as well. Although machines can juggle with a much larger set
of variables, poorly understood code can result in bugs. [~snemeth] had been
doing code rewrite for Hadoop for many years. There is a few hiccups, but I
think there are positive net gains with his help, however so slightly that it
may seem. It will get people on the edge prior to release time because some
code are baked well during the cycle of development. It would be helpful to
show some performance number of the net result to boost the confidence for rest
of the community. In this case I think Sunil's pain point for submitApp covers
for this issue. Other issues should be discussed separately. It is near 3.3.0
release, unless we have good solid data points for performance gain, I would
suggest to slow down on the code rewrite for now.
> Replace all MockRM submit method definitions with a builder
> -----------------------------------------------------------
>
> Key: YARN-9052
> URL: https://issues.apache.org/jira/browse/YARN-9052
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments:
> YARN-9052-004withlogs-patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt,
> YARN-9052-testlogs003-justfailed.txt,
> YARN-9052-testlogs003-patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt,
> YARN-9052-testlogs004-justfailed.txt, YARN-9052.001.patch,
> YARN-9052.002.patch, YARN-9052.003.patch, YARN-9052.004.patch,
> YARN-9052.004.withlogs.patch, YARN-9052.005.patch, YARN-9052.006.patch,
> YARN-9052.007.patch, YARN-9052.008.patch, YARN-9052.009.patch,
> YARN-9052.009.patch, YARN-9052.testlogs.002.patch,
> YARN-9052.testlogs.002.patch, YARN-9052.testlogs.003.patch,
> YARN-9052.testlogs.patch
>
>
> MockRM has 31 definitions of submitApp, most of them having more than
> acceptable number of parameters, ranging from 2 to even 22 parameters, which
> makes the code completely unreadable.
> On top of unreadability, it's very hard to follow what RmApp will be produced
> for tests as they often pass a lot of empty / null values as parameters.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
