[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815211#comment-13815211
]
Mayank Bansal commented on YARN-987:
------------------------------------
bq. 1. Would you please fix the capitalization?
Done
bq. It seems not necessary that convertToXXXXReport is public as well.
Done
bq. It's better to use the constant in YarnConfiguration and
config.getClass/getClassByName.
Done
bq. No need to convert to string to assert equivalence. You can do that
directly with the ID instances. In addition, please assert some fields from the
application attempt, such as "host"
Done
bq. You can refer to RMAppImpl#createAndGetApplicationReport to decide what the
fields should be when the attempt is null.
Done
Thanks,
Mayank
> Adding History Service to use Store and converting Historydata to Report
> ------------------------------------------------------------------------
>
> Key: YARN-987
> URL: https://issues.apache.org/jira/browse/YARN-987
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Mayank Bansal
> Assignee: Mayank Bansal
> Attachments: YARN-987-1.patch, YARN-987-2.patch, YARN-987-3.patch,
> YARN-987-4.patch, YARN-987-5.patch, YARN-987-6.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
